Details
-
Bug
-
Status: Closed
-
Blocker
-
Resolution: Duplicate
-
None
-
None
-
source
Description
I looked at minizip and there are some things to do there. In particular, you don't want the encryption. PKWare is pretty clear about that not being in the free part of Zip and I suspect the one kept in InfoZip may be defective. Also the ASF incubator proposal says there is no cryptography. (While it is now safe to publish crypto in open source, it must still be registered and the easy way to avoid that is not to provide any.)
It looks like there are some changes needed to compile for x64 also. I got two build warnings about that when building under MSYS2 and g++.
The first reference at the end of zip.h is incorrect and 404s. It should now be to
http://www.info-zip.org/pub/infozip/doc/appnote-19981119-iz.zip (apparently a Y2K-inspired change or simply done to align with the use of 20xx dates in that directory [;<).
The PKWare reference is also incorrect. It would be better to use the APPNOTE reference that is used in common with OOXML and ODF.
Because of the copyright on these files, it is not clear what the best way to adjust them is. Is there a link to where they were obtained that could be included in attribution in a derivative? Is anyone upstream accepting patches? This corrected link for the one in the beginning of zip.h is now: http://www.winimage.com/zLibDll/minizip.html. It does offer minizip 1.1 and claim it works for x64 though.
PS: That web page points out how to get zlib for Windows, etc.
jan:
Ups, I was sure crypt was removed, thanks for catching this.
As peter mentioned, we should try to remove minizip, it is not really well suited to what we need (simple unpacking/packing of files).