Uploaded image for project: 'Continuum'
  1. Continuum
  2. CONTINUUM-651

DefaultContinuumScm.getScmRepository should not set project scm username/password if they are the empty string

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0.3
    • Core system
    • None

    Description

      Should be using StringUtils.isEmpty instead of doing a null check.

      if ( !StringUtils.isEmpty(project.getScmUsername()) )
      {
          providerRepository.setUser( project.getScmUsername() );
      
          if ( project.getScmPassword() != null )
          {
              providerRepository.setPassword( project.getScmPassword() );
          }
          else
          {
              providerRepository.setPassword( "" );
          }
      }
      

      Attachments

        Activity

          People

            evenisse Emmanuel Venisse
            jdidion John Didion
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment