[CONTINUUM-2765] Changes since last success appears to always compute no changes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.2, 1.5.0
• Fix Version/s: 1.5.0
• Assignee: Brent Atkinson
• Reporter: Brent Atkinson
• Created: 05/May/15 17:51
• Updated: 05/May/15 22:47
• Resolved: 05/May/15 22:47

Description

While attempting to find the root cause of CONTINUUM-2762, I discovered that the code to compute the changes since the last successful build (for display on the build results page and in notification emails) will never result in changes to display.

Specifically, DefaultContinuum.getChangesSinceLastSuccess(...) appears to be implemented with an algorithm matching the following pseudocode:

var changes = [ ]
var results = fetchResultsBetween(lastSuccessfulResult, currentBuildResult)
var currentBuildIndex = results.indexOf(currentBuildResult)
if (currentBuildIndex > 0) {
  for (var result in results, starting at currentBuildIndex) {
    changes.addUniqueChanges(result)
  }
}
return changes

The problem with this algorithm is that the fetched results never include the current build result, so no changes are ever computed.

Issue Links

• relates to: CONTINUUM-2762 Computation of previous SCM changes sometimes includes entire history