Uploaded image for project: 'Continuum'
  1. Continuum
  2. CONTINUUM-2702

Cannot add an argument to remove a profile ( -P!profile)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.1
    • Fix Version/s: 1.4.2
    • Labels:
      None
    • Environment:
      All

      Description

      I've a maven profile 'dev' in my project for local configuration.
      When I build my project, I want to remove the dev profile. maven provides the -P!dev command. In continuum version 1.3.4, adding this attribute was OK.

      In v1.4.1, there is an error ('!' detected as invalid character).

      To fix this, we should add '!' in the list of accepted character in 3 files :
      continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml

      continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/admin/BuildDefinitionTemplateAction-saveBuildDefinitionAsTemplate-validation.xml

      continuum/trunk/continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java

      In this 3 files, the argument validation pattern should accept '!'.

        Activity

        Hide
        batkinson Brent N Atkinson added a comment -

        Fixed in r1491143.

        Show
        batkinson Brent N Atkinson added a comment - Fixed in r1491143.
        Hide
        brettporter Brett Porter added a comment -

        Thanks for reporting this, some of the validations are certainly too aggressive. Do you mind submitting this fix in patch format, with tests to verify it to ensure that it is not lost in future? You'll find examples of other validations rules in the projects mentioned and continuum-webapp-test

        Show
        brettporter Brett Porter added a comment - Thanks for reporting this, some of the validations are certainly too aggressive. Do you mind submitting this fix in patch format, with tests to verify it to ensure that it is not lost in future? You'll find examples of other validations rules in the projects mentioned and continuum-webapp-test

          People

          • Assignee:
            batkinson Brent N Atkinson
            Reporter:
            grey Lei Guo
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development