Continuum
  1. Continuum
  2. CONTINUUM-2658

Support purging of working and release directories of build agents on a schedule

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.1
    • Component/s: Distributed Builds
    • Labels:
      None
    1. CONTINUUM-2658_2.patch
      62 kB
      Greg Michael Meneses
    2. CONTINUUM-2658_3.patch
      121 kB
      Greg Michael Meneses
    3. CONTINUUM-2658.patch
      115 kB
      Greg Michael Meneses

      Activity

      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Closed Closed
      1d 20h 57m 1 Maria Catherine Tan 26/Aug/11 04:36
      Mark Thomas made changes -
      Workflow jira [ 12948124 ] Default workflow, editable Closed status [ 12983552 ]
      Mark Thomas made changes -
      Project Import Sun Apr 05 21:12:18 UTC 2015 [ 1428268338676 ]
      Mark Thomas made changes -
      Workflow jira [ 12711301 ] Default workflow, editable Closed status [ 12740722 ]
      Mark Thomas made changes -
      Project Import Sun Apr 05 08:36:01 UTC 2015 [ 1428222961749 ]
      Hide
      Maria Catherine Tan added a comment -

      added missing unit test in r1238919

      Show
      Maria Catherine Tan added a comment - added missing unit test in r1238919
      Maria Catherine Tan made changes -
      Status Open [ 1 ] Closed [ 6 ]
      Fix Version/s 1.4.1 (Beta) [ 15104 ]
      Resolution Fixed [ 1 ]
      Hide
      Maria Catherine Tan added a comment -

      Patch applied in trunk r1162043. Thanks!

      I also modified when checking if executing directory purge is allowed or not to make sure that we won't allow purging of working copies when release is ongoing.

      Show
      Maria Catherine Tan added a comment - Patch applied in trunk r1162043. Thanks! I also modified when checking if executing directory purge is allowed or not to make sure that we won't allow purging of working copies when release is ongoing.
      Hide
      Greg Michael Meneses added a comment -

      Filed CONTINUUM-2661 regarding UI notification for purge executions.

      Show
      Greg Michael Meneses added a comment - Filed CONTINUUM-2661 regarding UI notification for purge executions.
      Greg Michael Meneses made changes -
      Attachment CONTINUUM-2658_3.patch [ 56594 ]
      Hide
      Greg Michael Meneses added a comment -

      Please disregard CONTINUUM-2658_2.patch, was not able to include the new classes.

      Please use CONTINUUM-2658_3.patch instead for the fix on the release execution condition.

      Show
      Greg Michael Meneses added a comment - Please disregard CONTINUUM-2658 _2.patch, was not able to include the new classes. Please use CONTINUUM-2658 _3.patch instead for the fix on the release execution condition.
      Greg Michael Meneses made changes -
      Attachment CONTINUUM-2658_2.patch [ 56593 ]
      Hide
      Greg Michael Meneses added a comment -

      Fixed the condition to determine if the build agent is currently executing a release.

      Included the rollback queue and the checking if any (perform-release, prepare-release and rollback-release) of the executors is currently executing a task

      Show
      Greg Michael Meneses added a comment - Fixed the condition to determine if the build agent is currently executing a release. Included the rollback queue and the checking if any (perform-release, prepare-release and rollback-release) of the executors is currently executing a task
      Hide
      Maria Catherine Tan added a comment -

      I was able to purge the working copies while currently preparing release.

      Show
      Maria Catherine Tan added a comment - I was able to purge the working copies while currently preparing release.
      Hide
      Maria Catherine Tan added a comment - - edited

      I think there should also be a notification in UI if unable to purge for some reason.

      Currently, we still have to check the build agent logs to find out that the purge did not execute at all.

      Show
      Maria Catherine Tan added a comment - - edited I think there should also be a notification in UI if unable to purge for some reason. Currently, we still have to check the build agent logs to find out that the purge did not execute at all.
      Hide
      Maria Catherine Tan added a comment -

      The log says:

      Directory purge [directoryType=releases, daysOlder=0, retentionCount=0, deleteAll=false] not possible; Build Agent busy
      

      I didn't see the "not possible" text earlier so I think that should be ok now

      Show
      Maria Catherine Tan added a comment - The log says: Directory purge [directoryType=releases, daysOlder=0, retentionCount=0, deleteAll=false] not possible; Build Agent busy I didn't see the "not possible" text earlier so I think that should be ok now
      Hide
      Maria Catherine Tan added a comment -

      Patch looks good but haven't tried it yet.

      My only comment is when build is executing or the release is on going, can you add a more descriptive log message instead of just saying that the "Build Agent is busy" or "Build Agent is executing a release" or "Unable to determine if Build Agent is executing a release."

      If I saw that message, I would not know that the purge was not executed because the build agent is busy.

      Show
      Maria Catherine Tan added a comment - Patch looks good but haven't tried it yet. My only comment is when build is executing or the release is on going, can you add a more descriptive log message instead of just saying that the "Build Agent is busy" or "Build Agent is executing a release" or "Unable to determine if Build Agent is executing a release." If I saw that message, I would not know that the purge was not executed because the build agent is busy.
      Greg Michael Meneses made changes -
      Attachment CONTINUUM-2658.patch [ 56580 ]
      Hide
      Greg Michael Meneses added a comment -

      Attached patch for support

      Show
      Greg Michael Meneses added a comment - Attached patch for support
      Maria Catherine Tan made changes -
      Field Original Value New Value
      Assignee Maria Catherine Tan [ ctan ]
      Greg Michael Meneses created issue -

        People

        • Assignee:
          Maria Catherine Tan
          Reporter:
          Greg Michael Meneses
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development