[CONTINUUM-2294] wrong notifier type leaves project in an unuseable state

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.2.3
• Component/s: Notifier - Mail
• Labels: backlog-to-cleanup
• Assignee: Unassigned
• Reporter: Boris Gruschke
• Created: 10/Jul/09 14:30
• Updated: 20/Nov/12 01:09

Description

With this typo in a notifier configuration (note the "email" instead of "mail")

<ciManagement>
<notifiers>
<notifier>
<type>email</type>
<address>[e-mail]</address>
</notifier>
</notifiers>
</ciManagement>

I get a weird project state in continuum. The icon of the project is "building" and you cannot start or terminate the build. But actually it is not building.
I checked the log and found this entry

2009-07-09 12:55:29,716 [btpool0-6] INFO continuum - Enqueuing 'xxx' with build definition 'default maven2 buildDefinition' - id=34).
2009-07-09 12:55:29,729 [pool-1-thread-1] INFO buildController - Initializing build
2009-07-09 12:55:29,805 [pool-1-thread-1] INFO buildController - Starting build of xxx
2009-07-09 12:55:29,860 [Thread-18] ERROR taskQueueExecutor#build-project - Error executing task
edu.emory.mathcs.backport.java.util.concurrent.ExecutionException: java.lang.NullPointerException
at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.getResult(FutureTask.java:301)
at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.get(FutureTask.java:130)
at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.waitForTask(ThreadedTaskQueueExecutor.java:165)
at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.run(ThreadedTaskQueueExecutor.java:127)
Caused by: java.lang.NullPointerException
at org.apache.maven.continuum.notification.DefaultContinuumNotificationDispatcher.sendNotification(DefaultContinuumNotificationDispatcher.java:201)
at org.apache.maven.continuum.notification.DefaultContinuumNotificationDispatcher.sendNotification(DefaultContinuumNotificationDispatcher.java:184)
at org.apache.maven.continuum.notification.DefaultContinuumNotificationDispatcher.buildStarted(DefaultContinuumNotificationDispatcher.java:71)
at org.apache.maven.continuum.buildcontroller.DefaultBuildController.startBuild(DefaultBuildController.java:321)
at org.apache.maven.continuum.buildcontroller.DefaultBuildController.build(DefaultBuildController.java:116)
at org.apache.maven.continuum.buildcontroller.BuildProjectTaskExecutor.executeTask(BuildProjectTaskExecutor.java:50)
at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable$1.run(ThreadedTaskQueueExecutor.java:116)
at edu.emory.mathcs.backport.java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:178)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1061)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:575)
at java.lang.Thread.run(Thread.java:619)

It works fine with the correct "mail". But I don't think a typo should leave the project in an unuseable state.

I haven't got a working continuum+svn here, so I haven't tried to reproduce it with an 1.3 build.