[CONTINUUM-2119] Cleaning up large working directories fails with OutOfMemoryError

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.3
• Fix Version/s: 1.4.3
• Component/s: Core system
• Flags: Patch
• Assignee: Brent Atkinson
• Reporter: Frank Förstemann
• Created: 10/Mar/09 03:40
• Updated: 05/Apr/15 22:46
• Resolved: 31/Jan/15 08:30

Description

The action clean-working-directory runs out of heap space while cleaning up huge working directories (30GB / 500.000 files & directories in our case):

2009-03-08 06:00:14,582 [pool-1-thread-1] INFO buildController - Initializing build
2009-03-08 06:00:15,286 [pool-1-thread-1] INFO buildController - Starting build of ivu_plan_nightly_build
2009-03-08 06:00:15,301 [pool-1-thread-1] INFO buildController - Purging exiting working copy
2009-03-08 06:00:15,301 [pool-1-thread-1] INFO buildController - Performing action clean-working-directory
2009-03-08 06:31:39,209 [Thread-3] ERROR taskQueueExecutor#build-project - Error executing task
edu.emory.mathcs.backport.java.util.concurrent.ExecutionException: java.lang.OutOfMemoryError: Java heap space
at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.getResult(FutureTask.java:301)
at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.get(FutureTask.java:120)
at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.waitForTask(ThreadedTaskQueueExecutor.java:159)
at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.run(ThreadedTaskQueueExecutor.java:127)
Caused by: java.lang.OutOfMemoryError: Java heap space

The issue seems to be caused by the implementation in CleanWorkingDirectoryAction: the FileSetManager used to delete the working directory first scans all files & directores to create an object representation of the tree and then deletes the tree by scanning through the objects. As no filter condition is required using org.codehaus.plexus.util.FileUtils to directly delete the tree would avoid these kind of problems.

I'll attach a patch based on 1.2.3.

Issue Links

• is related to: MCLEAN-32 Out of Memory Error cleaning target directory with *large* number of sub-directories
• is related to: CONTINUUM-1156 Continuum will not successfully delete build directories containing symbolic links