Uploaded image for project: 'Continuum'
  1. Continuum
  2. CONTINUUM-1777

Able to create a build template without build definition

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1, 1.4.1
    • Fix Version/s: 1.4.2
    • Component/s: None
    • Labels:
      None
    • Flags:
      Patch

      Description

      Creating and editing a build definition template.
      It creates and saves the template without having a value in the Used Build Definition side.

      1. continuum-1777.patch
        9 kB
        John Michael Luy
      2. continuum-1777-tests.patch
        5 kB
        Gwen Harold Autencio

        Issue Links

          Activity

          Hide
          wsmoak Wendy Smoak added a comment -

          Confimed in 1.4.0-SNAPSHOT r814049. I can add a Build Definition Template without moving any Build Defs over to the 'Used' column. It should require at least one Build Definition before allowing the template to be saved.

          Also make sure that you cannot delete a Build Definition if it is in use by any Template. Or perhaps it's okay to delete it as long as it doesn't leave any Template with no other Build Defs.

          Show
          wsmoak Wendy Smoak added a comment - Confimed in 1.4.0-SNAPSHOT r814049. I can add a Build Definition Template without moving any Build Defs over to the 'Used' column. It should require at least one Build Definition before allowing the template to be saved. Also make sure that you cannot delete a Build Definition if it is in use by any Template. Or perhaps it's okay to delete it as long as it doesn't leave any Template with no other Build Defs.
          Hide
          jmluy John Michael Luy added a comment -

          Attached patch that will disallow saving of template without any definition. Also will disallow deleting of a build definition that is in use by a template.

          Show
          jmluy John Michael Luy added a comment - Attached patch that will disallow saving of template without any definition. Also will disallow deleting of a build definition that is in use by a template.
          Hide
          gautencio Gwen Harold Autencio added a comment -

          Hi,
          attaching unit and webapp test of John's patch.

          Show
          gautencio Gwen Harold Autencio added a comment - Hi, attaching unit and webapp test of John's patch.

            People

            • Assignee:
              batkinson Brent N Atkinson
              Reporter:
              ctan Maria Catherine Tan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development