Continuum
  1. Continuum
  2. CONTINUUM-1694

Adding Number of Errors and Test Success Rate to Notification Email

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2.1
    • Component/s: Notifier - Mail
    • Labels:
      None
    • Environment:
      Windows Vista
    • Flags:
      Patch

      Description

      To have the number of tests in error and the success rate of tests in the notification mail sent after every build.

      Why is it required - Because, currently the mail gives a wrong sense of success rate in tests where as there may be a good number of tests in error. Even though, ppl can go and check the online report, having the summary in the mails is important.

      Was there any reason behind excluding test errors? - Not Sure

        Activity

        Murali Mohan created issue -
        Hide
        Murali Mohan added a comment -

        The patch for this request is attached. Please review this and commit, if good. A Junit test also has been changed to test the changes. The changes are minor

        Show
        Murali Mohan added a comment - The patch for this request is attached. Please review this and commit, if good. A Junit test also has been changed to test the changes. The changes are minor
        Murali Mohan made changes -
        Field Original Value New Value
        Attachment CONTINUUM-1694.patch [ 33210 ]
        Olivier Lamy (*$^¨%`£) made changes -
        Assignee Olivier Lamy [ olamy ]
        Affects Version/s 2.0 [ 14021 ]
        Affects Version/s 1.2 [ 13779 ]
        Testcase included yes
        Patch Submitted [Yes]
        Brett Porter made changes -
        Fix Version/s 1.2 [ 13779 ]
        Hide
        Joel Turkel added a comment - - edited

        With your fix it looks like the failure details aren't being reported properly for test errors. I believe the fix is to swap lines 185 and 186 in continuum-reports\src\main\java\org\apache\maven\continuum\reports\surefire\ReportTestSuite.java. Also the velocity template should probably be updated to include test failures/errors section if there are test failures or test errors.

        Show
        Joel Turkel added a comment - - edited With your fix it looks like the failure details aren't being reported properly for test errors. I believe the fix is to swap lines 185 and 186 in continuum-reports\src\main\java\org\apache\maven\continuum\reports\surefire\ReportTestSuite.java. Also the velocity template should probably be updated to include test failures/errors section if there are test failures or test errors.
        Wendy Smoak made changes -
        Fix Version/s 1.2.1 [ 14539 ]
        Fix Version/s 1.2.0 [ 13779 ]
        Hide
        Emmanuel Venisse added a comment -

        Ptch applied in r.703056. Thanks.

        Show
        Emmanuel Venisse added a comment - Ptch applied in r.703056. Thanks.
        Emmanuel Venisse made changes -
        Resolution Fixed [ 1 ]
        Assignee Olivier Lamy [ olamy ] Emmanuel Venisse [ evenisse ]
        Status Open [ 1 ] Closed [ 6 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 08:36:01 UTC 2015 [ 1428222961749 ]
        Mark Thomas made changes -
        Workflow jira [ 12710351 ] Default workflow, editable Closed status [ 12740057 ]
        Mark Thomas made changes -
        Flags Patch [ 10430 ]
        Patch Submitted Yes [ 10763 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 21:12:18 UTC 2015 [ 1428268338676 ]
        Mark Thomas made changes -
        Workflow jira [ 12948569 ] Default workflow, editable Closed status [ 12985811 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        207d 17h 57m 1 Emmanuel Venisse 09/Oct/08 00:58

          People

          • Assignee:
            Emmanuel Venisse
            Reporter:
            Murali Mohan
          • Votes:
            3 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development