[CONNECTORS-226] Usage and meaning of ManifoldCFException type REPOSITORY_CONNECTION_ERROR needs to be reviewed and clarified

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3
• Fix Version/s: ManifoldCF 0.3
• Component/s: Framework core, JCIFS connector, LiveLink connector
• Assignee: Karl Wright
• Reporter: Karl Wright
• Created: 26/Jul/11 09:02
• Updated: 12/Aug/11 12:13
• Resolved: 12/Aug/11 12:13

Description

The ManifoldCFException type REPOSITORY_CONNECTION_ERROR seems to be treated by the framework somewhat inconsistently. In some places it is treated as a permanent connection exception, and in others as a temporary connection exception (in lieu of a ServiceInterruption where ServiceInterruption is not possible). Only two connectors use it (LiveLink and jCIFS), and the JCIFS case is not interesting. So really this is currently here to support Livelink.

There are two ways forward. The first way is to convert the Livelink connector's exception to a true ServiceInterruption, and revert REPOSITORY_CONNECTION_ERROR to its original meaning, which has now been deprecated as a result of the fact that connect() methods can no longer throw ManifoldCFExceptions at all. The second is to continue the current Livelink-style usage, and make ALL usages consistent with that.