[CONNECTORS-1590] Resources should be closed in a finally block

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: ManifoldCF 2.12
• Fix Version/s: ManifoldCF 2.13
• Component/s: Framework core
• Assignee: Karl Wright
• Reporter: Cihad Guzel
• Created: 03/Mar/19 11:23
• Updated: 03/Mar/19 13:07
• Resolved: 03/Mar/19 13:07

Description

public class DBInterfaceHSQLDB extends Database implements IDBInterface {
  ...
  try
      {
        Connection c = DriverManager.getConnection(_localUrl+databaseName,userName,password);
        Statement s = c.createStatement();
        s.execute("SHUTDOWN");
        c.close();
      }
      catch (Exception e)
      {
        // Never any exception!
        e.printStackTrace();
      }

Connections that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. That close call must be made in a finally block otherwise an exception could keep the call from being made.