[CONNECTORS-1126] Lock manager's lock ordering not working as designed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: ManifoldCF 1.7.2
• Fix Version/s: ManifoldCF 1.9, ManifoldCF 2.1
• Component/s: Framework core
• Assignee: Karl Wright
• Reporter: Karl Wright
• Created: 19/Dec/14 07:23
• Updated: 20/Dec/14 11:05
• Resolved: 19/Dec/14 07:27

Description

The LockGate logic for flushing a LockGate is as follows:

    synchronized (lockObject)
    {
      if (lockObject.leaveReadLock())
      {
        if (lockPool != null)
          lockPool.releaseObject(lockKey, this);
      }
    }

Unfortunately, this has the side effect of causing the nicely ordered thread queue to be destroyed on the first time a lock is exited. That kills ordering and makes LockGate essentially do nothing of value.