[CONFIGURATION-834] ConfirgurationPropertySource doesn't supply resolved values.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.10.0
• Component/s: Interpolation, Type conversion
• Assignee: Unassigned
• Reporter: Keith Barlow
• Created: 10/Jul/23 17:20
• Updated: 13/Jul/23 00:01
• Resolved: 12/Jul/23 23:46

Description

Per https://commons.apache.org/proper/commons-configuration/userguide/howto_utilities.html#Use_Configuration_in_Spring, we should be able to supply a Configuration to Spring using a ConfigurationPropertySource to tell spring to obtain property values from Commons Configuration2, however it seems that the ConfigurationPropertySource uses getProperty() instead of getString() to supply values to Spring.  This means that the value supplied to string is the literal element from the configuration file and not the value resolved by Apache Commons Configuration2.  This ultimately leads to Spring trying to parse a syntax it doesn't understand.

When defining values that are resolved from environment properties such as:

property.custom=${env:CUSTOM_PROPERTY_VALUE}

Spring will receive the literal value of '${env:CUSTOM_PROPERTY_VALUE}' and ultimately treat this as a default value for a property named 'env' instead of an environment variable reference.   

I was able to resolve this by updating ConfigurationPropertSource to use `source.getString(name)` instead, then Spring will receive the value Commons Configuration2 has resolved from the environment value and convert it accordingly on it's own.

Issue Links

• links to: GitHub Pull Request #309