Commons Configuration
  1. Commons Configuration
  2. CONFIGURATION-12

[configuration] fix project.xml to avoid cruft in resulting jar

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Nightly Builds
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: other
      Platform: All

      Description

      The commons-configuration-x.y.jat contains unnecessarily all configuration files from the test.
      I've attached a patch for the POM that runs all tests, but avoids the cruft in the resulting assembly.

      1. ASF.LICENSE.NOT.GRANTED--project.xml.diff
        2 kB
        joerg.schaible@gmx.de
      2. ASF.LICENSE.NOT.GRANTED--project.properties.diff
        0.7 kB
        joerg.schaible@gmx.de

        Activity

        Hide
        joerg.schaible@gmx.de added a comment -

        Created an attachment (id=11037)
        project.xml.diff

        Show
        joerg.schaible@gmx.de added a comment - Created an attachment (id=11037) project.xml.diff
        Hide
        joerg.schaible@gmx.de added a comment -

        Created an attachment (id=11038)
        project.properties.diff

        Show
        joerg.schaible@gmx.de added a comment - Created an attachment (id=11038) project.properties.diff
        Hide
        David Eric Pugh added a comment -

        Jorg, can you check this out? I applied your patch, however I did include
        digesterRules.xml, as I think that is required to run ConfigurationFactory..
        You can override ConfigurationFactory with your own rules if you provide a
        different digesterRules.xml.

        ERic

        Show
        David Eric Pugh added a comment - Jorg, can you check this out? I applied your patch, however I did include digesterRules.xml, as I think that is required to run ConfigurationFactory.. You can override ConfigurationFactory with your own rules if you provide a different digesterRules.xml. ERic
        Hide
        joerg.schaible@gmx.de added a comment -

        Hi Eric,

        I was not aware of, that files are really needed at runtime ... tests passed anyway (but no wonder,
        text-classes it in the classpath during unit tests). Maybe we should reorganize this after the release,
        since you have normally src/conf and src/test-conf in Maven as standard.

        Regards,
        Jörg

        Show
        joerg.schaible@gmx.de added a comment - Hi Eric, I was not aware of, that files are really needed at runtime ... tests passed anyway (but no wonder, text-classes it in the classpath during unit tests). Maybe we should reorganize this after the release, since you have normally src/conf and src/test-conf in Maven as standard. Regards, Jörg
        Hide
        Emmanuel Bourg added a comment -

        I don't think digesterRules.xml is needed, the new <system/> elements worked
        fined without changing this file.

        Show
        Emmanuel Bourg added a comment - I don't think digesterRules.xml is needed, the new <system/> elements worked fined without changing this file.

          People

          • Assignee:
            Unassigned
            Reporter:
            Joerg Schaible
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development