Uploaded image for project: 'Commons Compress'
  1. Commons Compress
  2. COMPRESS-79

Move DOS/Java time conversions into Zip utility class

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Component/s: None
    • Labels:
      None

      Description

      ZipFile.dosToJavaTime()
      and
      ZipArchiveOutputStream.toDosTime()

      could be moved to a common utilities package and made public.

      toDosTime() should use Calendar to agree with dosToJavaTime().

      Maybe toDosTime() should be renamed as javaToDosTime() to agree with the reverse.

      ZipFile.fromDosTime() does not appear to be used, and the protected ZipArchiveOutputStream.toDosTime() is only used in a Test class

      There should probably also be some tests for the methods (which would be easier to do with public methods).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: