[COMPRESS-684] Why use assert rather than throwing an Exception

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: Unassigned
• Reporter: Sebb
• Created: 25/Jul/24 16:03
• Updated: 29/Jul/24 19:31
• Resolved: 29/Jul/24 19:31

Description

The code here uses assert:

https://github.com/apache/commons-compress/blob/b6c6b1e71087ae3e31d1024069084512a243eed7/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java#L207

This seems odd for user code, as the assert may be disabled.

It would be more usual to throw an Exception instead.

Issue Links

• links to: GitHub Pull Request #549