[COMPRESS-644] ArchiveStreamFactory.detect(InputStream) returns TAR for ICO file

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.23.0
• Fix Version/s: 1.26.1
• Assignee: Unassigned
• Reporter: Tim Allison
• Created: 12/May/23 12:14
• Updated: 04/Mar/24 14:38
• Resolved: 04/Mar/24 14:38

Description

Over on Tika, this file is being detected as a tar file. It is an os/2 bitmap array file.

We're using ArchiveStreamFactory.detect(), which finds no magic so it gets down to:

tais = new TarArchiveInputStream(new ByteArrayInputStream(tarHeader));
                                if (tais.getNextTarEntry().isCheckSumOK())

The next tar entry has length 0 and the checksum of 0 works.

If you're up for it, it might make sense to check that the next tar entry has a length > 0.

I realize that this is a trivial/rare problem with a rare or specially crafted file. And, I realize that this only fixes one special case. I'm not sure it makes sense to add complexity to your logic.

Issue Links

• links to: GitHub Pull Request #386