Uploaded image for project: 'Commons Compress'
  1. Commons Compress
  2. COMPRESS-64

Are the public finish() methods ArchiveOutputStream implementations necessary and safe?

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.0
    • 1.0
    • None
    • None

    Description

      Some of the ArchiveOutputStream implementations have public finish() methods. These are currently only called from the close() methods.

      Seems to me that there is no need to allow the finish() methods to be called externally, and the user can corrupt the output if they do.

      Surely the close() method is all that is needed?

      Attachments

        Activity

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: