[COMPRESS-60] ChangeSet does not synchronise whilst using the Iterator

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0
• Assignee: Christian Grobmeier
• Reporter: Sebb
• Created: 27/Mar/09 23:54
• Updated: 02/May/23 17:11
• Resolved: 09/Apr/09 11:17

Description

ChangeSet does not synchronize whilst using the Iterator on the Set "changes" which is a synchronizedSet.

The Javadoc for Collections.synchronizedSet says: "
...
It is imperative that the user manually synchronize on the returned set when iterating over it:
...
Failure to follow this advice may result in non-deterministic behavior."

This affects the add() and perfom() methods.

Also, the asSet() method returns a reference to the Set. This method does not seem to be used at present, so perhaps could be removed.
Otherwise, it should either return a copy of the set, or the Javadoc should point out that any iteration over the set must synchronize on the set.