[COMPRESS-55] CpioArchiveEntry ignores invalid modes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 26/Mar/09 13:14
• Updated: 02/May/23 17:11
• Resolved: 31/Mar/09 19:17

Description

CpioArchiveEntry has the following code:

        default:
            // FIXME: testCpioUnarchive fails if I change the line to
            // actually throw the excpetion
            new IllegalArgumentException("Unknown mode (full mode: " + mode
                    + ", masked mode: " + (mode & S_IFMT));
        }

As the comment says, rejecting invalid modes causes test failures.

These appear to be caused by the code

{bq}

this.cpioEntry.setMode(0);

in the method CpioArchiveOutputStream.finish()

Is a mode of 0 allowed? If so, then setMode needs to allow it, otherwise the method call needs to change to something else.