Uploaded image for project: 'Commons Compress'
  1. Commons Compress
  2. COMPRESS-435

Use Switch Instead of InstanceOf For Snappy/LZ4

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 1.15
    • 1.16
    • Compressors
    • None

    Description

      Instead of checking for instanceof in determining block types emitted from Snappy/LZ4, use Enumerator + Switch statement.

      My micro-benchmarks indicate about a 1% performance improvement over the current implementation.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            belugabehr David Mollitor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment