Commons Compress
  1. Commons Compress
  2. COMPRESS-39

A few upstream (Ant) changes to the ZIP package

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None

      Description

      I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.

      http://svn.apache.org/viewvc?rev=738844&view=rev
      use more modern collections (since Ant trunk now officially is JDK 1.4+). This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.

      http://svn.apache.org/viewvc?rev=738853&view=rev
      make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
      Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559

      http://svn.apache.org/viewvc?rev=739300&view=rev
      skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
      Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940

      There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
      https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.

      Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

        Activity

        Hide
        Stefan Bodewig added a comment - - edited

        all three patches have been merged, the last one was svn revision 740657.

        Show
        Stefan Bodewig added a comment - - edited all three patches have been merged, the last one was svn revision 740657.
        Hide
        Stefan Bodewig added a comment -

        I hope you meant to say that you'd be happy for me to commit the stuff 8-)

        I've committed the second and third patch since I'm unsure about the JDK baseline required by compress, I'll take this to the dev list.

        Since I'm unsure about tracking policies in commons (again, I'll ask on list), the related svn revisions are 740604 and 740605.

        Show
        Stefan Bodewig added a comment - I hope you meant to say that you'd be happy for me to commit the stuff 8-) I've committed the second and third patch since I'm unsure about the JDK baseline required by compress, I'll take this to the dev list. Since I'm unsure about tracking policies in commons (again, I'll ask on list), the related svn revisions are 740604 and 740605.
        Hide
        Torsten Curdt added a comment - - edited

        Collaboration on this sounds like a good idea. In fact you are more than welcome to commit the changes yourself if you like

        Show
        Torsten Curdt added a comment - - edited Collaboration on this sounds like a good idea. In fact you are more than welcome to commit the changes yourself if you like

          People

          • Assignee:
            Torsten Curdt
            Reporter:
            Stefan Bodewig
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development