[COMPRESS-328] TarArchiveEntry preserveLeadingSlashes has no effect on setName

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.11
• Assignee: Torsten Curdt
• Reporter: Torsten Curdt
• Created: 06/Jan/16 12:39
• Updated: 15/Jan/16 14:37
• Resolved: 15/Jan/16 14:37

Description

We've run into an inconsistency with the TarArchiveEntry at jdeb.

https://github.com/tcurdt/jdeb/issues/217

You can create a `TarArchiveEntry(String name, boolean preserveLeadingSlashes)` but the `preserveLeadingSlashes` is only applied in the constructor.

https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java#L392

I am proposing to turn `preserveLeadingSlashes` into a read-only property and use the value on `setName()`, too (instead of just false).

This has some implications and maybe some backwards compatibility issues - but even then I think it would be the right thing to do.

I am happy to make the change but thought to discuss this first.