Uploaded image for project: 'Commons Compress'
  1. Commons Compress
  2. COMPRESS-27

BZip2CompressorInputStream.reportCRCError() does not report problems to user

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.0
    • None
    • None

    Description

      BZip2CompressorInputStream.reportCRCError() merely writes an error message to System.err; it should really throw an IOException as indicated in the method signature.

      The IOException message should probably show the expected and actual CRCs.

      Or at least the method should set a flag that can be tested by the caller.

      The code says it does this because "previous versions of the class did" - however this does not apply, as there are no previous versions released.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment