Details
-
Type:
Improvement
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.4.1
-
Fix Version/s: 1.5
-
Component/s: Compressors
-
Labels:None
Description
If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.
Activity
slightly modified version of your patch went in with svn revision 1358814
Thanks!
I was not sure on what java compatibility level the code was supposed to be so i made this java 4 combatible. I have converted my own version to an enum however so i now also attached an extended enum version. I did choose the radio button for license to ASF, however i hereby confirm that i license both the patch and the enum code to the ASF (Grant license to ASF for inclusion in ASF works - as per the Apache License §5). You are welcome!
Variant of ZipMethod as enum
I think ZipMethod could be an enum.
I'm not sure whether you have checked the "license to the ASF" checkbox when attaching the file. There used to be a feather logo but I don't see one anymore. Could you please confirm you are licensing the path tothe ASF? Thanks.
For a project of my own, i created a enum style class for ZipMethods which contains methods i identified and names / descriptions for them and extended the UnsupportedZipFeatureException to use this names / descriptions for these features
Patch for extended UnsupportedZipFeatureException
with readable name for more commonly used methods
Oh, we used to require Java 1.4 compatibility up until Compress 1.3 and are at Java5 right now.