[COMPRESS-157] Wrong EOF detection in CBZip2InputStream

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0
• Assignee: Unassigned
• Reporter: Jan
• Created: 16/Sep/11 12:08
• Updated: 16/Sep/11 15:18
• Resolved: 16/Sep/11 14:57

Description

The following snippet form CBZip2InputStream does a wrong EOF check. The char 'thech' will never be equal to the integer '-1'. You have to check for #read() returning -1 before casting to char.

I found the bug in http://svn.wikimedia.org/svnroot/mediawiki/trunk/mwdumper/src/org/apache/commons/compress/bzip2/ not in your TRUNK.

                            int zzi;
                            char thech = 0;
                            try
                            {
                                thech = (char)m_input.read();
                            }
                            catch( IOException e )
                            {
                                compressedStreamEOF();
                            }
                            if( thech == -1 ) //HERE
                            {
                                compressedStreamEOF();
                            }

Issue Links

• is related to: VFS-363 Wrong EOF detection in CBZip2InputStream