Commons All
  1. Commons All
  2. COMMONSSITE-69

Commons parent uses maven.compile.[source|target] rather than maven.compiler.[source|target]

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Commons parent uses the property name maven.compile.[source|target] rather than maven.compiler.[source|target] as used by the Maven Compiler plugin itself [1]

      This is a bit confusing.

      Consider whether this should be changed to agree with the standard Maven property name.

      Or indeed to change it to use a commons-specific property name.

      This would mean that components would have to rename the property in their POM when they updated to the new commons parent POM.

      If the parent pom is changed to use the standard Maven names, then it could be simplified by removing the <source> and <target> configuration elements (but this should not be considered a good reason to change the name, only a minor benefit if we do).

      [1] http://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#source

        Activity

        Hide
        Ate Douma added a comment -

        I notice this change has been done and released with c-p 32, meaning components upgrading to this latest c-p pom will have to modify their Maven build properties.
        However several documentation pages have not been updated/fixed for this change yet, like:

        http://commons.apache.org/commons-parent-pom.html#Configuring_the_Java_SourceTarget_options
        http://commons.apache.org/releases/prepare.html#Configure_the_Build_to_Generate_a_Complete_Set_of_Release_Artifacts
        http://commons.apache.org/releases/prepare.html#Class_File_Format

        Show
        Ate Douma added a comment - I notice this change has been done and released with c-p 32, meaning components upgrading to this latest c-p pom will have to modify their Maven build properties. However several documentation pages have not been updated/fixed for this change yet, like: http://commons.apache.org/commons-parent-pom.html#Configuring_the_Java_SourceTarget_options http://commons.apache.org/releases/prepare.html#Configure_the_Build_to_Generate_a_Complete_Set_of_Release_Artifacts http://commons.apache.org/releases/prepare.html#Class_File_Format

          People

          • Assignee:
            Unassigned
            Reporter:
            Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development