[COLLECTIONS-759] An issue about the failed with CI about the checkstyle of NewlineAtEndOfFile.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.5.0-M1
• Assignee: Bruno P. Kinoshita
• Reporter: Chen Guoping
• Created: 14/Apr/20 03:28
• Updated: 23/Apr/20 03:53
• Resolved: 23/Apr/20 03:53

Description

commons-collections\src\conf\checkstyle.xml
<module name="NewlineAtEndOfFile">
<property name="lineSeparator" value="lf" />
</module>
The link of CI

[ERROR] src/main/java/org/apache/commons/collections4/ArrayUtils.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
[ERROR] src/test/java/org/apache/commons/collections4/queue/SynchronizedQueueTest.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
[ERROR] src/test/java/org/apache/commons/collections4/junit/AbstractAvailableLocalesTest.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
[ERROR] src/test/java/org/apache/commons/collections4/junit/SetDefaultLocaleTestRule.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
[ERROR] src/test/java/org/apache/commons/collections4/junit/ObjectToStringComparator.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:41 min
[INFO] Finished at: 2020-04-09T07:11:16Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on project commons-collections4: You have 5 Checkstyle violations. -> [Help 1]

But I test the checkstyel locally with cmd :
mvn clean ; mvn checkstyle:checkstyle
The result is
Summary
Files Info Warnings Errors
590 0 0 590
Details
org/apache/commons/collections4/AbstractArrayListTest.java
Severity Category Rule Message Line
Error misc NewlineAtEndOfFile Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. 1
Can the checkstyle NewlineAtEndOfFile be warning not error ?
I don't think the checkstyle would affect the used with the software.

Issue Links

• links to: GitHub Pull Request #147