[COLLECTIONS-701] StackOverflowError in SetUniqueList.add() when it receives itself

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.2.2
• Fix Version/s: 4.3
• Component/s: Collection
• Flags: Important
• Assignee: Unassigned
• Reporter: Shin Hong
• Created: 31/Oct/18 12:38
• Updated: 09/Jun/24 22:27
• Resolved: 23/Nov/18 07:32

Description

Hi.

We found that the following test case fails with a StackOverFlowError exception:

test() {        
   SetUniqueList l = new SetUniqueList(new LinkedList<Object>()) ;        
   l.add((Object) l) ;    
}

The add() execution traps into an infinite recursion which crashes the program.

From the stack trace, we found that the infinite recursion occurs

at AbstractList.hashCode() since it invokes hashCode() of each of its elements.

 

Issue Links

• is related to: JCR-4608 Upgrade to commons-collections4
• links to: GitHub Pull Request #57