[COLLECTIONS-524] ListOrderedSet can have duplicates

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.1, 4.0
• Fix Version/s: 4.1

Environment

tomcat 7, linux

• Assignee: Unassigned
• Reporter: J Goodfellow
• Created: 06/May/14 00:58
• Updated: 27/Nov/15 21:11
• Resolved: 06/May/14 22:14

Description

The static method, org.apache.commons.collections.set.ListOrderedSet.decorate(List list), has a comment "If the list contains duplicates, the duplicates are removed". It does not remove duplicates and will leave you in an inconsistent state if your list has duplicates. (i.e. the .size() result is smaller than the number of iterations from the iterator)