[COLLECTIONS-280] Add Predicate that failed PredicatedCollection.validate to IllegalArgumentException text

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Collection

Environment

N/A

• Assignee: Unassigned
• Reporter: Chris Lewis
• Created: 05/Dec/07 02:10
• Updated: 09/Nov/14 14:31
• Resolved: 28/Feb/13 20:04

Description

In a project I'm working on at the moment, I decorate some of my sets with multiple Predicates. In the event that validation fails, it would be nice to know which predicate caused the failure.

I'd suggest changing the validate method in PredicatedCollection to:

protected void validate(Object object) {
if (predicate.evaluate(object) == false)

{ throw new IllegalArgumentException("Cannot add Object '" + object + "' - Predicate '" + predicate + "' rejected it"); }

}

Then, the user can provide a toString method with relevant information about the Predicate and why it might cause the validation to fail if they choose.