[COLLECTIONS-276] *Utils classes should not be extensible or able to be instantiated.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 3.2
• Assignee: Unassigned
• Reporter: Stephen Kestle
• Created: 11/Nov/07 21:39
• Updated: 01/May/14 10:36
• Resolved: 12/Nov/07 11:19

Description

I don't see any good reason why this CollectionUtils (and others) isn't final with a private constructor. There are no non-static methods, and any extension of them is going to have to call through to the super to avoid compiler warnings.

e.g. MyCollectionUtils.select() will provoke the warning that "static methods should be called directly" (on CollectionUtils).

Which would mean
MyCollectionUtils{
public static Collection select(){
return CollectionUtils.select();
}

Which really defeats the purpose. In Java5, we have static imports now - these provide more benefit than previous extension did anyhow.

Issue Links

• breaks: COLLECTIONS-519 private constructors in utility classes break existing code