[COLLECTIONS-218] CollectionUtils.select() does not return passed in collection

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Core
• Assignee: Stephen Kestle
• Reporter: Stephen Kestle
• Created: 18/Jul/06 23:16
• Updated: 09/Nov/14 14:31
• Resolved: 28/Feb/13 19:36

Description

collect has the following methods:

Collection collect(Collection inputCollection, final Transformer transformer)
Collection collect(Collection inputCollection, final Transformer transformer, final Collection outputCollection)

The first creates an ArrayList(), where the second takes an outputCollection and, for convenience, returns it.

Select (and selectReject) currently the following methods:

Collection select(Collection inputCollection, Predicate predicate)
void select(Collection inputCollection, Predicate predicate, Collection outputCollection)

I propose changing the bottom method to return the passed in outputCollection. It would simplify calling code.