[CODEC-320] Wrong output of DoubleMetaphone in 1.16.1

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.17.0
• Flags: Patch
• Assignee: Unassigned
• Reporter: Martin Frydl
• Created: 04/Mar/24 16:59
• Updated: 18/Apr/24 19:51
• Resolved: 18/Apr/24 19:50

Description

It looks like there is a bug in DoubleMetaphone implementation in version 1.16.1. Older 1.16.0 is fine. In fact I'm not 100% sure it is a bug, but it behaves differently and the old output looks much more reasonable than the new one.

Old code contains index+=2 -
https://github.com/apache/commons-codec/blob/rel/commons-codec-1.16.0/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java#L462
New code does not contain that line -
https://github.com/apache/commons-codec/blob/rel/commons-codec-1.16.1/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java#L619