[CODEC-232] URLCodec is neither immutable nor threadsafe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10
• Fix Version/s: 1.11
• Assignee: Unassigned
• Reporter: Sebb
• Created: 28/Mar/17 13:51
• Updated: 28/Mar/17 14:02
• Resolved: 28/Mar/17 14:02

Description

URLCodec Javadoc says the class is immutable and threadsafe.

However it is not immutable, because of the fields:

protected static final BitSet WWW_FORM_URL;
protected String charset;

Nor is it threadsafe, because external code can change the charset field; changes to the field are not safely published across threads.

(The WWW_FORM_URL field is no longer used internally).

The class could be made effectively immutable (and threadsafe) by also saving the initial charset name in a private final field and only using the private field.

Or the charset field could be made volatile.
This would preserve the behaviour for subclasses that rely on changing the charset field.