Uploaded image for project: 'Commons Codec'
  1. Commons Codec
  2. CODEC-151

Remove unnecessary attempt to fill up the salt variable in UnixCrypt

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.6
    • 1.7

    Description

      https://github.com/lathspell/commons-codec/commit/878618cecb7b2f03550f0bb0e6642ca96187cbae

      Note that the "// NOOP" comment was misleading, the salt variable
      actually was modified inside the for loop.

      This functionality will never be used though as the salt is checked
      some lines above to an exact length of 2. Filling it with "A" would
      be a very bad idea anyway as e.g. glibc fills a one-char salt with
      exactly the same char so our implementation would have been incompatible!

      Attachments

        Activity

          People

            Unassigned Unassigned
            lathspell Christian Brunotte
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: