Uploaded image for project: 'Commons Codec'
  1. Commons Codec
  2. CODEC-146

Add JUnit tests that use BeiderMorse like Solr does

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7
    • Labels:
      None

      Description

      I noticed that Solr-3.6.0 uses the following parts of commons-codec directly:

      oacc.language.bm.Languages$LanguageSet.from(java.util.Set)

      oacc.language.bm.PhoneticEngine.encode(String, Languages.LanguageSet)

      oacc.language.bm.NameType.valueOf(String)

      oacc.language.bm.RuleType.valueOf(String)

      But our JUnit tests do not reference these parts of commons-codec directly. I don't really understand BeiderMorse encoding, but based on the code I saw in Solr, I've created some unit tests to ensure we don't ever accidentally break the way they're using us.

      Since I'm not a BM person, I would prefer if someone else reviews this and commits it.

        Attachments

        1. codec-146.patch
          12 kB
          Julius Davies

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              juliusdavies Julius Davies
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: