Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.0.0-alpha-3
-
Fix Version/s: 3.0.0-alpha-3
-
Component/s: cocoon-sax, cocoon-sitemap
-
Labels:None
Description
As reported in the summary, the LinkRewriter Transformer needs to be integrated in the sitemap
Activity
Hi Francesco,
what you said makes a lot of sense, I just wondered if it is possible allow users define their concrete implementations and plug them in the sitemap. Would it make sense, or providing just a default one is enough? WDYT?
Many thanks in advance and thanks for your collaboration!
what you said makes a lot of sense, I just wondered if it is possible allow users define their concrete implementations and plug them in the sitemap. Would it make sense, or providing just a default one is enough? WDYT?
Many thanks in advance and thanks for your collaboration!
Show
Simone Tripodi
added a comment - Hi Francesco,
what you said makes a lot of sense, I just wondered if it is possible allow users define their concrete implementations and plug them in the sitemap. Would it make sense, or providing just a default one is enough? WDYT?
Many thanks in advance and thanks for your collaboration!
IMHO it would be nice to either define a concrete implementation in C3 source code (more or less like in C2.1 and C2.2) and also to add somewhere in the documentation that users can provide their own implementation, if and when they have such a need.
Show
Francesco Chicchiriccò
added a comment - IMHO it would be nice to either define a concrete implementation in C3 source code (more or less like in C2.1 and C2.2) and also to add somewhere in the documentation that users can provide their own implementation, if and when they have such a need.
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Cocoon Developers Team [ cocoon ] |
In this patch there is a concrete subclass of AbstractLinkRewriterTransformer, RegexpLinkRewriterTransformer that rewrites links on a pattern matching basis.
The patch also contains an extension to cocoon-sample with the purpose of showing a sample usage of the transformer.
Do you think that this solution could work?
The patch also contains an extension to cocoon-sample with the purpose of showing a sample usage of the transformer.
Do you think that this solution could work?
Show
Francesco Chicchiriccò
added a comment - In this patch there is a concrete subclass of AbstractLinkRewriterTransformer, RegexpLinkRewriterTransformer that rewrites links on a pattern matching basis.
The patch also contains an extension to cocoon-sample with the purpose of showing a sample usage of the transformer.
Do you think that this solution could work?
| Attachment | RegexpLinkRewriter.patch [ 12473164 ] |
+1 for applying the patch
Show
Simone Tripodi
added a comment - +1 for applying the patch
| Assignee | Francesco Chicchiriccò [ ilgrosso ] |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] |
Should it be the case to write down a complete LinkRewriterTransformer (like http://cocoon.apache.org/2.2/blocks/linkrewriter/1.0/1102_1_1.html)?
Otherwise, what does "integrate in the sitemap" means for an abstract class?