Cocoon 3
  1. Cocoon 3
  2. COCOON3-56

The LinkRewriter Transformer needs to be integrated in the sitemap

    Details

      Description

      As reported in the summary, the LinkRewriter Transformer needs to be integrated in the sitemap
      1. RegexpLinkRewriter.patch
        48 kB
        Francesco Chicchiriccò

        Activity

        Simone Tripodi created issue -
        Hide
        Francesco Chicchiriccò added a comment -
        At the moment in the source an AbstractLinkRewriterTransformer exists, without any concrete implementation.
        Should it be the case to write down a complete LinkRewriterTransformer (like http://cocoon.apache.org/2.2/blocks/linkrewriter/1.0/1102_1_1.html)?

        Otherwise, what does "integrate in the sitemap" means for an abstract class?
        Show
        Francesco Chicchiriccò added a comment - At the moment in the source an AbstractLinkRewriterTransformer exists, without any concrete implementation. Should it be the case to write down a complete LinkRewriterTransformer (like http://cocoon.apache.org/2.2/blocks/linkrewriter/1.0/1102_1_1.html)? Otherwise, what does "integrate in the sitemap" means for an abstract class?
        Hide
        Simone Tripodi added a comment -
        Hi Francesco,
        what you said makes a lot of sense, I just wondered if it is possible allow users define their concrete implementations and plug them in the sitemap. Would it make sense, or providing just a default one is enough? WDYT?
        Many thanks in advance and thanks for your collaboration!
        Show
        Simone Tripodi added a comment - Hi Francesco, what you said makes a lot of sense, I just wondered if it is possible allow users define their concrete implementations and plug them in the sitemap. Would it make sense, or providing just a default one is enough? WDYT? Many thanks in advance and thanks for your collaboration!
        Hide
        Francesco Chicchiriccò added a comment -
        IMHO it would be nice to either define a concrete implementation in C3 source code (more or less like in C2.1 and C2.2) and also to add somewhere in the documentation that users can provide their own implementation, if and when they have such a need.
        Show
        Francesco Chicchiriccò added a comment - IMHO it would be nice to either define a concrete implementation in C3 source code (more or less like in C2.1 and C2.2) and also to add somewhere in the documentation that users can provide their own implementation, if and when they have such a need.
        Mark Thomas made changes -
        Field Original Value New Value
        Assignee Cocoon Developers Team [ cocoon ]
        Hide
        Francesco Chicchiriccò added a comment -
        In this patch there is a concrete subclass of AbstractLinkRewriterTransformer, RegexpLinkRewriterTransformer that rewrites links on a pattern matching basis.

        The patch also contains an extension to cocoon-sample with the purpose of showing a sample usage of the transformer.

        Do you think that this solution could work?
        Show
        Francesco Chicchiriccò added a comment - In this patch there is a concrete subclass of AbstractLinkRewriterTransformer, RegexpLinkRewriterTransformer that rewrites links on a pattern matching basis. The patch also contains an extension to cocoon-sample with the purpose of showing a sample usage of the transformer. Do you think that this solution could work?
        Francesco Chicchiriccò made changes -
        Attachment RegexpLinkRewriter.patch [ 12473164 ]
        Hide
        Simone Tripodi added a comment -
        +1 for applying the patch
        Show
        Simone Tripodi added a comment - +1 for applying the patch
        Francesco Chicchiriccò made changes -
        Assignee Francesco Chicchiriccò [ ilgrosso ]
        Francesco Chicchiriccò made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Francesco Chicchiriccò
            Reporter:
            Simone Tripodi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development