Cocoon 3
  1. Cocoon 3
  2. COCOON3-38

Cocoon-monitoring base information about Servlet-Services

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha-2
    • Fix Version/s: 3.0.0-alpha-2
    • Component/s: cocoon-monitoring
    • Labels:
      None

      Description

      Add ability of sharing base information about Servlet-Services like points of mount or connections.
      1. cocoon-servlet-srvices-impl-connections.patch
        0.6 kB
        Dariusz Łuksza
      2. servlet-services-doc.patch
        2 kB
        Dariusz Łuksza
      3. servlet-services-doc1.patch
        2 kB
        Dariusz Łuksza
      4. servlet-services-monitor.patch
        8 kB
        Dariusz Łuksza
      5. servlet-services-monitor1.patch
        32 kB
        Dariusz Łuksza
      6. servlet-services-monitor2.patch
        3 kB
        Dariusz Łuksza

        Activity

        Reinhard Poetz made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Reinhard Poetz made changes -
        Component/s cocoon-monitoring [ 12313010 ]
        Component/s cocoon-optional [ 12312514 ]
        Hide
        Reinhard Poetz added a comment -
        The use of "break" was of course incorrect. I will also change the bean naming strategy as suggested by you.
        Show
        Reinhard Poetz added a comment - The use of "break" was of course incorrect. I will also change the bean naming strategy as suggested by you.
        Dariusz Łuksza made changes -
        Attachment servlet-services-monitor2.patch [ 12413594 ]
        Hide
        Dariusz Łuksza added a comment -
        This patch replace all "service-servlet" typos into "servlet-service".

        Additionally I've changed "brake" statements in class ServletServiceMonitorInitializer into log statement and "continue", IMHO that solution fits best, because we initialize monitoring service for all servlets that we can do not only for that, that are before first one that we can't initialize.

        BTW. Maybe now we can change bean naming strategy from "<full servlet name> [<mount patch>]" into "<mount patch> [<full servlet name>]" ? IMHO it would be more readable for users.
        Show
        Dariusz Łuksza added a comment - This patch replace all "service-servlet" typos into "servlet-service". Additionally I've changed "brake" statements in class ServletServiceMonitorInitializer into log statement and "continue", IMHO that solution fits best, because we initialize monitoring service for all servlets that we can do not only for that, that are before first one that we can't initialize. BTW. Maybe now we can change bean naming strategy from "<full servlet name> [<mount patch>]" into "<mount patch> [<full servlet name>]" ? IMHO it would be more readable for users.
        Hide
        Reinhard Poetz added a comment -
        I applied servlet-services-monitor1.patch with some minor modifactions: I use a private accessor to get all the connections and their names because otherwise we would need to introduce an dependency on cocoon-servlet-service-impl-1.3.0-SNAPSHOT. As soon as 1.2.1 is released this can be changed (see ServletServiceMonitor).
        Apart from that I added the mount path to the bean name.
        Show
        Reinhard Poetz added a comment - I applied servlet-services-monitor1.patch with some minor modifactions: I use a private accessor to get all the connections and their names because otherwise we would need to introduce an dependency on cocoon-servlet-service-impl-1.3.0-SNAPSHOT. As soon as 1.2.1 is released this can be changed (see ServletServiceMonitor). Apart from that I added the mount path to the bean name.
        Reinhard Poetz made changes -
        Assignee Cocoon Developers Team [ cocoon ] Reinhard Poetz [ reinhard@apache.org ]
        Dariusz Łuksza made changes -
        Attachment servlet-services-doc1.patch [ 12412569 ]
        Hide
        Dariusz Łuksza added a comment -
        Patch for cocoon-docs adds description of cocoon-monitoring Servlet-Service.
        Show
        Dariusz Łuksza added a comment - Patch for cocoon-docs adds description of cocoon-monitoring Servlet-Service.
        Reinhard Poetz made changes -
        Fix Version/s 3.0.0-alpha-2 [ 12313446 ]
        Dariusz Łuksza made changes -
        Attachment servlet-services-monitor1.patch [ 12411359 ]
        Hide
        Dariusz Łuksza added a comment - - edited
        Implemented new features mentioned by Reinhard in mail (http://mail-archives.apache.org/mod_mbox/cocoon-dev/200906.mbox/%3c4A36B428.6060301@apache.org%3e)

        1) I would prefer having all servlet services as nodes in the tree of mbeans (similar to what Jetty does with servlets) and
        2) also expose the servlet parameters.
        3) show the short name of a connection additionally to the fully qualified bean name
        Show
        Dariusz Łuksza added a comment - - edited Implemented new features mentioned by Reinhard in mail ( http://mail-archives.apache.org/mod_mbox/cocoon-dev/200906.mbox/%3c4A36B428.6060301@apache.org%3e ) 1) I would prefer having all servlet services as nodes in the tree of mbeans (similar to what Jetty does with servlets) and 2) also expose the servlet parameters. 3) show the short name of a connection additionally to the fully qualified bean name
        Dariusz Łuksza made changes -
        Attachment servlet-services-doc.patch [ 12410542 ]
        Attachment servlet-services-monitor.patch [ 12410543 ]
        Hide
        Dariusz Łuksza added a comment -
        Patches for cocoon-monitoring and cocoon-doc projects that adds described new features.
        Show
        Dariusz Łuksza added a comment - Patches for cocoon-monitoring and cocoon-doc projects that adds described new features.
        Dariusz Łuksza made changes -
        Field Original Value New Value
        Attachment cocoon-servlet-srvices-impl-connections.patch [ 12410541 ]
        Hide
        Dariusz Łuksza added a comment -
        Patch for implementation Cocoon Servlet-Service that adds possibility of getting connections for Service-Servlet.
        Show
        Dariusz Łuksza added a comment - Patch for implementation Cocoon Servlet-Service that adds possibility of getting connections for Service-Servlet.
        Dariusz Łuksza created issue -

          People

          • Assignee:
            Reinhard Poetz
            Reporter:
            Dariusz Łuksza
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development