Cocoon
  1. Cocoon
  2. COCOON-2213

Change check on mime-type to enable custom encoding of the body

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.11, 2.2.1
    • Fix Version/s: 2.1.12, 2.2.1
    • Component/s: Blocks: Mail
    • Labels:
      None
    • Other Info:
      Patch available
    • Affects version (Component):
      Blocks: Mail - 1.0.0
    • Fix version (Component):
      Blocks: Mail - 1.1.0-SNAPSHOT

      Description

      Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.

      COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
      1. SendMailTransformer_mime-type.patch
        1 kB
        Jasha Joachimsthal
      2. SendMailTransformer-plaintext.patch
        1 kB
        Jasha Joachimsthal

        Activity

        Hide
        Jasha Joachimsthal added a comment -
        Seems like one code changes breaks setting a charset on plain/text mails. I couldn't find your change in one of the patches for this issue or COCOON-1622. Created a patch to revert this.
        Show
        Jasha Joachimsthal added a comment - Seems like one code changes breaks setting a charset on plain/text mails. I couldn't find your change in one of the patches for this issue or COCOON-1622 . Created a patch to revert this.
        Hide
        Alfred Nathaniel added a comment -
        Applied your patch and synchronized branch and trunk versions.
        That means that http://svn.apache.org/viewvc?view=rev&revision=314933 is now backported to 2.1
        and that http://issues.apache.org/jira/browse/COCOON-1622 is now also in 2.2.

        Please check and close issue.
        Show
        Alfred Nathaniel added a comment - Applied your patch and synchronized branch and trunk versions. That means that http://svn.apache.org/viewvc?view=rev&revision=314933 is now backported to 2.1 and that http://issues.apache.org/jira/browse/COCOON-1622 is now also in 2.2. Please check and close issue.
        Hide
        Jasha Joachimsthal added a comment -
        Useful in cases like
        <email:body mime-type="text/html;charset=UTF-8">
        </email:body>
        <email:body mime-type="text/plain;charset=UTF-8">
        </email:body>
        Show
        Jasha Joachimsthal added a comment - Useful in cases like <email:body mime-type="text/html;charset=UTF-8"> </email:body> <email:body mime-type="text/plain;charset=UTF-8"> </email:body>
        Hide
        Jasha Joachimsthal added a comment -
        Patch with changed mime-type check
        Show
        Jasha Joachimsthal added a comment - Patch with changed mime-type check

          People

          • Assignee:
            Alfred Nathaniel
            Reporter:
            Jasha Joachimsthal
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development