Cocoon
  1. Cocoon
  2. COCOON-2178

Array-based constructors of TreeSelectionEvent used.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.11
    • Fix Version/s: 2.1.12
    • Component/s: Blocks: Forms
    • Labels:
      None
    • Urgency:
      Normal
    • Other Info:
      Patch available
    • Affects version (Component):
      Blocks: Forms - 1.0.0-RC3-SNAPSHOT
    • Fix version (Component):
      Blocks: Forms - 1.1.0-SNAPSHOT

      Description

      I'm facing a serious problem using the cforms tree.

      We added a new functionality: when a user doubleclicks an item, all subitems are selected as well. The result is that for every selected subitem an event is thrown. The problem, as mentioned in the source code, is that the array based constructor of the TreeSelectionEvent is not used. (Besides some other minor changes).

      I have adapted the org.apache.cocoon.forms.formmodel.tree.Tree class and it works fine. But we'll face a problem after updating, so please tell me how i could contribute my code.
      1. Tree.diff
        2 kB
        Harald Entner

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        12d 18h 7m 1 Jörg Heinicke 31/Mar/08 04:56
        Jörg Heinicke made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Fix version (Component) Parent values: Blocks: Forms(10239). Parent values: Blocks: Forms(10239). Level 1 values: 1.1.0-SNAPSHOT(10324).
        Fix Version/s 2.1.12-dev (Current SVN) [ 12312903 ]
        Hide
        Jörg Heinicke added a comment -
        I applied a slightly different patch making the code more equal to the single selection. I think I didn't reintroduce the multiple events ;)
        Show
        Jörg Heinicke added a comment - I applied a slightly different patch making the code more equal to the single selection. I think I didn't reintroduce the multiple events ;)
        Jörg Heinicke made changes -
        Affects version (Component) Parent values: Blocks: Forms(10167). Level 1 values: 1.1.0-SNAPSHOT(10323). Parent values: Blocks: Forms(10167). Level 1 values: 1.0.0-RC3-SNAPSHOT(10331).
        Affects Version/s 2.2-dev (Current SVN) [ 12310611 ]
        Fix Version/s 2.2-dev (Current SVN) [ 12310611 ]
        Fix Version/s 2.1.11 [ 12312231 ]
        Fix version (Component) Parent values: Blocks: Forms(10239). Level 1 values: 1.1.0-SNAPSHOT(10324). Parent values: Blocks: Forms(10239).
        Jörg Heinicke made changes -
        Assignee Jörg Heinicke [ joerg.heinicke@gmx.de ]
        Harald Entner made changes -
        Field Original Value New Value
        Attachment Tree.diff [ 12378245 ]
        Hide
        Harald Entner added a comment -
        Unique Diff of the Tree class.

        It's not packaged, as it is only one file.
        Show
        Harald Entner added a comment - Unique Diff of the Tree class. It's not packaged, as it is only one file.
        Hide
        Vadim Gritsenko added a comment -
        Harald, this should help you get started:
        http://cocoon.apache.org/2.1/howto/howto-patch.html
        Show
        Vadim Gritsenko added a comment - Harald, this should help you get started: http://cocoon.apache.org/2.1/howto/howto-patch.html
        Harald Entner created issue -

          People

          • Assignee:
            Jörg Heinicke
            Reporter:
            Harald Entner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development