[COCOON-1869] MailMessageSender.java eats exception chain

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.9
• Fix Version/s: 2.1.10, 2.2
• Component/s: Blocks: Mail
• Other Info: Patch available
• Assignee: Jörg Heinicke
• Reporter: Kaj Kandler
• Created: 26/Jun/06 05:11
• Updated: 09/Oct/06 19:19
• Resolved: 09/Oct/06 19:19

Description

line 448 eats the chain of exceptions, which is bad for finding bugs and misconfiguration.

It should better read:

        } catch (MessagingException me) {
            throw me;

or

        } catch (MessagingException me) {
            throw me; // new MessagingException(me.getMessage(),me);

or be eliminated all together, following the principle, if you can't do anything about an exception and don't need to aggregate it, because of API design, don't catch it in the first place!