Uploaded image for project: 'Chemistry (Retired)'
  1. Chemistry (Retired)
  2. CMIS-871

Client API Atompub binding - getContentChanges still sends change log token even though I specify null for the changeLogToken parameter

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • OpenCMIS 0.12.0
    • None
    • opencmis-client
    • Windows 64 bits

    Description

      I found 2 OpenCMIS Client API problems in my test to use OpenCMIS Client API Session.getContentChanges(String changeLogToken, boolean includeProperties).

      The test is calling it like session.getContentChanges(null, false); You see I set null to changeLogToken. Based on my understanding of CMIS specification, I assume that the API would not include a change log token in the request.

      The problems I found are

      1. OpenCMIS API send a changeLogToken anyway in Atompub binding but null in Web services binding. The latter is compliant with CMIS specification but the former is not. I think the OpenCMIS API in Atompub binding has a bug.

      2. This API sends a default maxItems in request because our test doesn't specify one. However OpenCMIS API sends an unreasonable maxItem 2147483647. I think it is the maximum value of a java integer. It causes different effect in Atompub and web services bindings.

      In Atompub binding, because of the bug (a change log token is passed in), CMIS passed the change log token and the maxItems in the query, the query returns the change events after the change log token. Therefore the test cases passed.

      In web services binding, the null value change log token and the maxItems will effectively return the entire change log from the repository. It causes the query hang and eventually timed out after 300 seconds.

      This JIRA is reporting the first problem. I am not sure if the second problem (maxItems = 2147483647 by default) is a problem. Because CMIS specification doesn't say anything about the default maxItems. We will do something at server side to prevent such a unreasonable maxItems to be used in query.

      Attachments

        Activity

          People

            Unassigned Unassigned
            vincentt126 Vincent Tang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: