[CMIS-844] POSTHttpServletRequestWrapper should accommodate prior consumption of request body by a filter

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: OpenCMIS 0.12.0
• Fix Version/s: OpenCMIS 0.13.0
• Component/s: opencmis-server
• Assignee: Florian Müller
• Reporter: Ron Gavlin
• Created: 20/Sep/14 05:08
• Updated: 17/Dec/14 09:42
• Resolved: 17/Dec/14 09:42

Description

POSTHttpServletRequestWrapper should accommodate prior consumption of the request body by a filter.

The 0.7.0 release provided this accommodation. This appears to have been broken by the major post-0.7.0 refactoring.

The following POSTHttpServletRequestWrapper constructor modification fixes the problem:

...
        if (isMultipart) {
...
        } else {
            // form data processing
            StringBuilder sb = new StringBuilder();

            InputStreamReader sr = new InputStreamReader(request.getInputStream(), IOUtils.UTF8);
            char[] buffer = new char[4096];
            int c = 0;
            while ((c = sr.read(buffer)) > -1) {
                sb.append(buffer, 0, c);
            }

            if (sb.length() < 3) {
                @SuppressWarnings("unchecked")
                Map<String, String[]> parameterMap = request.getParameterMap();
                getParameterMap().putAll(parameterMap);
            } else {
                parseFormData(sb.toString());
            }
        }
...