Uploaded image for project: 'Chemistry (Retired)'
  1. Chemistry (Retired)
  2. CMIS-728

JUnitHelper silently swallows exceptions

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • OpenCMIS 0.10.0
    • OpenCMIS 0.12.0
    • opencmis-tck
    • None

    Description

      The class org.apache.chemistry.opencmis.tck.impl.JUnitHelper is not helping much
      We use it to run the TCK, but whenever an exception occurs as part of these tests, it gets swallowed by this line, and we lose precious information on what actually happened:

      Assert.fail(e.getMessage());
      

      It would be better to attach the whole stack trace to the failure message.
      However, I think the simplest would be to let the Exceptions pass and pop at the surface.
      Here is a patch to do just that, if it helps.
      Thanks!

      Attachments

        1. CMIS-728.patch
          2 kB
          Samuel Langlois

        Activity

          People

            fmui Florian Müller
            slanglois Samuel Langlois
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: