[CMIS-142] SimpleReadWriteTests.testCreateDocument incorrect acl assertion?

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.1.0-incubating
• Component/s: opencmis-client-bindings
• Assignee: Florian Müller
• Reporter: David Caruana
• Created: 01/Mar/10 19:04
• Updated: 14/Jun/10 13:56
• Resolved: 01/Mar/10 22:15

Description

AbstractSimpleReadWriteTests (line 116):

if (supportsManageACLs()) {
AccessControlEntry ace = getObjectFactory().createAccessControlEntry(getUsername(),
Collections.singletonList("cmis:read"));
AccessControlList acl = getObjectFactory().createAccessControlList(
Collections.singletonList(ace));

AccessControlList newAcl = getProvider().getAclService().applyAcl(getTestRepositoryId(),
docId, acl, null, getAclPropagation(), null);
assertNotNull(newAcl);

This test case does not provide a removeAces value to applyAcl. Subsequently, in AbstractAtomPubService (line 508) the following check is made:

if ((removeAces == null) || (removeAces.getAces() == null))

{ throw new IllegalArgumentException("remove ACEs must not be null!"); }

The above assertion always seem to fail for SimpleReadWriteTests.testCreateDocument.