[CMIS-1045] Successful deletion of folder (204 NO CONTENT) returns FailedToDeleteData

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: DotCMIS 0.7
• Component/s: dotcmis

Environment

Alfresco 5.2.0

• Assignee: Unassigned
• Reporter: Nicolas Raoul
• Created: 08/Sep/17 07:00
• Updated: 08/Sep/17 07:11
• Resolved: 08/Sep/17 07:11

Description

The CMIS 1.1 specification (chapter 3.11.4.3):

3.11.4.3 HTTP DELETE
This removes the folder from the repository. This is deletion of the folder only and not any contained objects.
CMIS Services:
    deleteObject 
Success Status Codes:
    204 No Content

After successfully deleting the folder, Alfresco correctly sends HTTP status 204 NO CONTENT.

Problematic source code: https://github.com/apache/chemistry-dotcmis/blob/trunk/DotCMIS/binding/atompub/atompub.cs#L2053

// check response code
if (resp.StatusCode == HttpStatusCode.OK || resp.StatusCode == HttpStatusCode.Accepted || resp.StatusCode == HttpStatusCode.NoContent)
{
    return new FailedToDeleteData();
}

It should be something like this:

if (resp.StatusCode != HttpStatusCode.NoContent)

... and the throw ConvertToCmisException(resp); at the end of the method needs to be modified too.

I have only observed this for folders, I have not checked all but other entities seems to have been written correctly.
Cheers!