[CLOUDSTACK-9314] Remove unused code from XenServerStorageProcessor and change methods access level

• Type: Improvement
• Status: Reopened
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 4.9.0
• Component/s: XenServer
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Unassigned
• Reporter: Gabriel Beims Bräscher
• Created: 19/Mar/16 23:37
• Updated: 31/Aug/17 07:34

Description

Remove unused code from "com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor" class and modify some methods access level.

Remove unused methods:

com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSRByNameLabel(Connection, String)
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getNfsSR(Connection, StorageFilerTO)
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.directDownloadHttpTemplate(CopyCommand, DecodedDataObject, DecodedDataObject)
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.execute(AttachPrimaryDataStoreCmd)

change access level:

from public to private: com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftUpload(Connection, SwiftTO, String, String, String, Boolean, int)
from public to protected: com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftBackupSnapshot(Connection, SwiftTO, String, String, String, Boolean, int)
from protected to private: com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSnapshotSize(Connection, String, String, Boolean, int)
from protected to private: com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.backupSnapshot(Connection, String, String, String, String, String, String, Boolean, int)

Issue Links

• links to: GitHub Pull Request #1443