Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.0, Future
    • Component/s: KVM
    • Security Level: Public (Anyone can view this level - this is the default.)
    • Labels:
    • Environment:
      Ubuntu 16.04, CentOS 7.X

      Description

      We currently only support sysvinit, but with CentOS and Ubuntu both moving to Systemd we should support systemd.

      To do this we can:

      • Loose JSVC
      • Log to stdout and let systemd / journalctl handling the logging

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c0fde9a12bf32d0d4009792d05b1648f7c6ea419 in cloudstack's branch refs/heads/master from Remi Bergsma
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c0fde9a ]

          Merge pull request #731 from remibergsma/centos7-kvm

          CLOUDSTACK-8443: Support CentOS 7 as KVM hypervisorThis adds support for CentOS 7 as a KVM hypervisor. As discussed in the Jira issue, the root cause of the issue was the `cloudstack-setup-agent` script that added this line to `/etc/libvirt/qemu.conf`:

          `cgroup_controllers=["cpu"]`

          On CentOS 6 this 'works', but since by default no cgroups are mounted, this setting is ignored by `libvirtd`. On CentOS 7 is does not work, because the `cpu` and `cpuacct` are 'co-mounted'. This simpy means you cannot use one without the order. The config line above instructs `libvirtd` to only use the `cpu` cgroup, which it can't.

          There was code added to make sure the `cpu` cgroup was not co-mounted. It did this with a shell script, but after a reboot it was gone. It wasn't reliable and not even a solution at all. I went ahead and removed the code, because the co-mounted cgroups work fine. The real issue was the config line we put in `/etc/libvirt/qemu.conf` so much better to fix that instead.

          The default for `libvirtd` is to use only cgroups that are mounted. When you remove the 'cgroup_controllers' line, the default kicks in. According to the `qemu.conf` file, the default is:

          `cgroup_controllers = ["cpu", "devices", "memory", "blkio", "cpuacct", "net_cls"]`

          Then again, if it's not mounted, it's not used. So, that's a nice way to control it.
          This works just fine for both RHEL/CentOS 6 and RHEL/CentOS 7.

          Along the debugging, I came across some small issues here and there which I also fixed in this PR.

          If you test this, be sure to build RPMs from this branch and install those on the KVM hypervisor.

          At Schuberg Philis we run KVM hypervisors on CentOS 7 for months with these fixes. Now I took the time to fix the issues in CloudStack, rather than work around them.

          @bhaisaab @karuturi could you please review this? Thanks!

          Please note:
          The next step is to fix CLOUDSTACK-8625 (Systemd profile for KVM Agent) as currently a sysvinit script is still used. Although it works, we do not have any systemd benefits. As it is a separate issue, I'll try to address it in a separate PR.

          Signed-off-by: Remi Bergsma <github@remi.nl>

          Show
          jira-bot ASF subversion and git services added a comment - Commit c0fde9a12bf32d0d4009792d05b1648f7c6ea419 in cloudstack's branch refs/heads/master from Remi Bergsma [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c0fde9a ] Merge pull request #731 from remibergsma/centos7-kvm CLOUDSTACK-8443 : Support CentOS 7 as KVM hypervisorThis adds support for CentOS 7 as a KVM hypervisor. As discussed in the Jira issue, the root cause of the issue was the `cloudstack-setup-agent` script that added this line to `/etc/libvirt/qemu.conf`: `cgroup_controllers= ["cpu"] ` On CentOS 6 this 'works', but since by default no cgroups are mounted, this setting is ignored by `libvirtd`. On CentOS 7 is does not work, because the `cpu` and `cpuacct` are 'co-mounted'. This simpy means you cannot use one without the order. The config line above instructs `libvirtd` to only use the `cpu` cgroup, which it can't. There was code added to make sure the `cpu` cgroup was not co-mounted. It did this with a shell script, but after a reboot it was gone. It wasn't reliable and not even a solution at all. I went ahead and removed the code, because the co-mounted cgroups work fine. The real issue was the config line we put in `/etc/libvirt/qemu.conf` so much better to fix that instead. The default for `libvirtd` is to use only cgroups that are mounted. When you remove the 'cgroup_controllers' line, the default kicks in. According to the `qemu.conf` file, the default is: `cgroup_controllers = ["cpu", "devices", "memory", "blkio", "cpuacct", "net_cls"] ` Then again, if it's not mounted, it's not used. So, that's a nice way to control it. This works just fine for both RHEL/CentOS 6 and RHEL/CentOS 7. Along the debugging, I came across some small issues here and there which I also fixed in this PR. If you test this, be sure to build RPMs from this branch and install those on the KVM hypervisor. At Schuberg Philis we run KVM hypervisors on CentOS 7 for months with these fixes. Now I took the time to fix the issues in CloudStack, rather than work around them. @bhaisaab @karuturi could you please review this? Thanks! Please note: The next step is to fix CLOUDSTACK-8625 (Systemd profile for KVM Agent) as currently a sysvinit script is still used. Although it works, we do not have any systemd benefits. As it is a separate issue, I'll try to address it in a separate PR. pr/731: CLOUDSTACK-8443 : detect CentOS 7.x as RHEL 7 alike CLOUDSTACK-8443 : mention the correct logfile CLOUDSTACK-8443 : display the right hypervisor type CLOUDSTACK-8443 : don't try to fix co-mounted cgroups Signed-off-by: Remi Bergsma <github@remi.nl>
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user wido opened a pull request:

          https://github.com/apache/cloudstack/pull/813

          CLOUDSTACK-8625: Systemd profile for CloudStack Agent

          With CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/wido/cloudstack CLOUDSTACK-8625

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cloudstack/pull/813.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #813


          commit 612c7ebf403cdafd3355d8b30f03885cb0f340d6
          Author: Wido den Hollander <wido@widodh.nl>
          Date: 2015-09-13T13:12:29Z

          CLOUDSTACK-8625: Systemd profile for CloudStack Agent

          With CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/813 CLOUDSTACK-8625 : Systemd profile for CloudStack Agent With CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wido/cloudstack CLOUDSTACK-8625 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/813.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #813 commit 612c7ebf403cdafd3355d8b30f03885cb0f340d6 Author: Wido den Hollander <wido@widodh.nl> Date: 2015-09-13T13:12:29Z CLOUDSTACK-8625 : Systemd profile for CloudStack Agent With CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/813#issuecomment-139873749

          @wido Cool, thank you! Will test tomorrow

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139873749 @wido Cool, thank you! Will test tomorrow
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/813#issuecomment-139897498

          Hey @wido.. question: I tried building the packages:
          `./package.sh -d centos7`

          Got this error:
          ```
          Processing files: cloudstack-agent-4.6.0-SNAPSHOT.el7.centos.x86_64
          error: File not found: /data/git/cs3/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/etc/init.d/cloudstack-agent

          RPM build errors:
          Binaries arch (1) not matching the package arch (2).
          File not found: /data/git/cs3/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/etc/init.d/cloudstack-agent
          RPM Build Failed
          ```

          In `./centos7/cloud.spec` line `491` I see:
          ```
          %attr(0755,root,root) %{_sysconfdir}/init.d/%

          {name}

          -agent
          ```

          I assume this line needs to be removed? Or am I missing something?

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139897498 Hey @wido.. question: I tried building the packages: `./package.sh -d centos7` Got this error: ``` Processing files: cloudstack-agent-4.6.0-SNAPSHOT.el7.centos.x86_64 error: File not found: /data/git/cs3/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/etc/init.d/cloudstack-agent RPM build errors: Binaries arch (1) not matching the package arch (2). File not found: /data/git/cs3/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/etc/init.d/cloudstack-agent RPM Build Failed ``` In `./centos7/cloud.spec` line `491` I see: ``` %attr(0755,root,root) %{_sysconfdir}/init.d/% {name} -agent ``` I assume this line needs to be removed? Or am I missing something?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/813#issuecomment-139907185

          @wido In order to get it to work on CentOS 7 I had to patch it like this. You may want to add it to the PR:

          ```
          diff --git a/packaging/centos7/cloud.spec b/packaging/centos7/cloud.spec
          index 0ecc406..2028981 100644
          — a/packaging/centos7/cloud.spec
          +++ b/packaging/centos7/cloud.spec
          @@ -488,7 +488,8 @@ fi
          %attr(0755,root,root) %{_bindir}/%

          {name}-setup-agent
          %attr(0755,root,root) %{_bindir}/%{name}

          -agent-upgrade
          %attr(0755,root,root) %{_bindir}/%

          {name}-ssh
          -%attr(0755,root,root) %{_sysconfdir}/init.d/%{name}

          -agent
          +%attr(0644,root,root) %{_unitdir}/%

          {name}-agent.service
          +%attr(0755,root,root) /usr/libexec/cloudstack/cloudstack-agent-systemd-wrapper.sh
          %attr(0644,root,root) %{_sysconfdir}/profile.d/%{name}

          -agent-profile.sh
          %attr(0755,root,root) %{_datadir}/%

          {name}-common/scripts/network/cisco
          %config(noreplace) %{_sysconfdir}/%{name}

          /agent
          ```

          Tested it on CentOS 7.1 KVM box and the `systemd` profile works great! If you update the PR with the above patch (or something with the same result) I'll give you my LGTM

          Thanks, Remi

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139907185 @wido In order to get it to work on CentOS 7 I had to patch it like this. You may want to add it to the PR: ``` diff --git a/packaging/centos7/cloud.spec b/packaging/centos7/cloud.spec index 0ecc406..2028981 100644 — a/packaging/centos7/cloud.spec +++ b/packaging/centos7/cloud.spec @@ -488,7 +488,8 @@ fi %attr(0755,root,root) %{_bindir}/% {name}-setup-agent %attr(0755,root,root) %{_bindir}/%{name} -agent-upgrade %attr(0755,root,root) %{_bindir}/% {name}-ssh -%attr(0755,root,root) %{_sysconfdir}/init.d/%{name} -agent +%attr(0644,root,root) %{_unitdir}/% {name}-agent.service +%attr(0755,root,root) /usr/libexec/cloudstack/cloudstack-agent-systemd-wrapper.sh %attr(0644,root,root) %{_sysconfdir}/profile.d/%{name} -agent-profile.sh %attr(0755,root,root) %{_datadir}/% {name}-common/scripts/network/cisco %config(noreplace) %{_sysconfdir}/%{name} /agent ``` Tested it on CentOS 7.1 KVM box and the `systemd` profile works great! If you update the PR with the above patch (or something with the same result) I'll give you my LGTM Thanks, Remi
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wido commented on the pull request:

          https://github.com/apache/cloudstack/pull/813#issuecomment-139913812

          @remibergsma I did and made another small change. I don't have a very good CentOS dev setup here, so I wasn't able to test it very thorough.

          I think this should work now.

          Show
          githubbot ASF GitHub Bot added a comment - Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139913812 @remibergsma I did and made another small change. I don't have a very good CentOS dev setup here, so I wasn't able to test it very thorough. I think this should work now.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/813#issuecomment-140185766

          LGTM - tested again with the new changes and the package build succeeds and the packages install fine on CentOS 7. Also tested start/stop/status and rebooted the box. All fine so GO! :+1:

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140185766 LGTM - tested again with the new changes and the package build succeeds and the packages install fine on CentOS 7. Also tested start/stop/status and rebooted the box. All fine so GO! :+1:
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wido commented on the pull request:

          https://github.com/apache/cloudstack/pull/813#issuecomment-140303120

          @bhaisaab Could you take a quick peek?

          Show
          githubbot ASF GitHub Bot added a comment - Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140303120 @bhaisaab Could you take a quick peek?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bhaisaab commented on the pull request:

          https://github.com/apache/cloudstack/pull/813#issuecomment-140650649

          LGTM :+1:

          Show
          githubbot ASF GitHub Bot added a comment - Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140650649 LGTM :+1:
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 612c7ebf403cdafd3355d8b30f03885cb0f340d6 in cloudstack's branch refs/heads/master from Wido den Hollander
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=612c7eb ]

          CLOUDSTACK-8625: Systemd profile for CloudStack Agent

          With CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 612c7ebf403cdafd3355d8b30f03885cb0f340d6 in cloudstack's branch refs/heads/master from Wido den Hollander [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=612c7eb ] CLOUDSTACK-8625 : Systemd profile for CloudStack Agent With CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4b3a8415b378dce7b00d7e3bccb97979f9d3fec3 in cloudstack's branch refs/heads/master from Wido den Hollander
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4b3a841 ]

          CLOUDSTACK-8625: Updated spec file for systemd profile

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4b3a8415b378dce7b00d7e3bccb97979f9d3fec3 in cloudstack's branch refs/heads/master from Wido den Hollander [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4b3a841 ] CLOUDSTACK-8625 : Updated spec file for systemd profile
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit df53776d4ed5e0a85824e97b2cc9cea5400adde8 in cloudstack's branch refs/heads/master from Wido den Hollander
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=df53776 ]

          CLOUDSTACK-8625: Remove the need of a wrapper script for the Agent

          We now inline execute 'sh' which does all the work

          Show
          jira-bot ASF subversion and git services added a comment - Commit df53776d4ed5e0a85824e97b2cc9cea5400adde8 in cloudstack's branch refs/heads/master from Wido den Hollander [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=df53776 ] CLOUDSTACK-8625 : Remove the need of a wrapper script for the Agent We now inline execute 'sh' which does all the work
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ]

          Merge pull request #813 from wido/CLOUDSTACK-8625

          CLOUDSTACK-8625: Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.

          Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ] Merge pull request #813 from wido/ CLOUDSTACK-8625 CLOUDSTACK-8625 : Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly. pr/813: CLOUDSTACK-8625 : Remove the need of a wrapper script for the Agent CLOUDSTACK-8625 : Updated spec file for systemd profile CLOUDSTACK-8443 : Install the systemd wrapper script in RPM CLOUDSTACK-8625 : Systemd profile for CloudStack Agent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ]

          Merge pull request #813 from wido/CLOUDSTACK-8625

          CLOUDSTACK-8625: Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.

          Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ] Merge pull request #813 from wido/ CLOUDSTACK-8625 CLOUDSTACK-8625 : Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly. pr/813: CLOUDSTACK-8625 : Remove the need of a wrapper script for the Agent CLOUDSTACK-8625 : Updated spec file for systemd profile CLOUDSTACK-8443 : Install the systemd wrapper script in RPM CLOUDSTACK-8625 : Systemd profile for CloudStack Agent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ]

          Merge pull request #813 from wido/CLOUDSTACK-8625

          CLOUDSTACK-8625: Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.

          Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ] Merge pull request #813 from wido/ CLOUDSTACK-8625 CLOUDSTACK-8625 : Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly. pr/813: CLOUDSTACK-8625 : Remove the need of a wrapper script for the Agent CLOUDSTACK-8625 : Updated spec file for systemd profile CLOUDSTACK-8443 : Install the systemd wrapper script in RPM CLOUDSTACK-8625 : Systemd profile for CloudStack Agent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ]

          Merge pull request #813 from wido/CLOUDSTACK-8625

          CLOUDSTACK-8625: Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.

          Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ] Merge pull request #813 from wido/ CLOUDSTACK-8625 CLOUDSTACK-8625 : Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly. pr/813: CLOUDSTACK-8625 : Remove the need of a wrapper script for the Agent CLOUDSTACK-8625 : Updated spec file for systemd profile CLOUDSTACK-8443 : Install the systemd wrapper script in RPM CLOUDSTACK-8625 : Systemd profile for CloudStack Agent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ]

          Merge pull request #813 from wido/CLOUDSTACK-8625

          CLOUDSTACK-8625: Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd
          it is preferred that CloudStack's Agent is also being started using
          systemd.

          This commit includes a service file for the CloudStack Agent with
          a wrapper script which actually executes Java

          It no longer uses jsvc for daemonizing and thus this requirement
          has also been dropped for CentOS 7 packaging.

          The Agent log output to stdout has also been modified to no longer
          include the timestamp as this is done by journalctl.

          This has been tested on a CentOS 7.1 machine and the Agent starts,
          stops and restarts properly.

          Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c5ea5f63fdf08b7812a38a092e82b776e39c669 in cloudstack's branch refs/heads/master from Rohit Yadav [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5ea5f ] Merge pull request #813 from wido/ CLOUDSTACK-8625 CLOUDSTACK-8625 : Systemd profile for CloudStack AgentWith CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using systemd. This commit includes a service file for the CloudStack Agent with a wrapper script which actually executes Java It no longer uses jsvc for daemonizing and thus this requirement has also been dropped for CentOS 7 packaging. The Agent log output to stdout has also been modified to no longer include the timestamp as this is done by journalctl. This has been tested on a CentOS 7.1 machine and the Agent starts, stops and restarts properly. pr/813: CLOUDSTACK-8625 : Remove the need of a wrapper script for the Agent CLOUDSTACK-8625 : Updated spec file for systemd profile CLOUDSTACK-8443 : Install the systemd wrapper script in RPM CLOUDSTACK-8625 : Systemd profile for CloudStack Agent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cloudstack/pull/813

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/813
          Hide
          widodh Wido den Hollander added a comment -

          Has been merged into master

          Show
          widodh Wido den Hollander added a comment - Has been merged into master

            People

            • Assignee:
              widodh Wido den Hollander
              Reporter:
              widodh Wido den Hollander
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development