[CLOUDSTACK-7312] ISO/volume format name checking is crude and doesn't work with advanced URLs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.0
• Fix Version/s: 4.5.0
• Component/s: Storage Controller
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Min Chen
• Reporter: Min Chen
• Created: 11/Aug/14 21:40
• Updated: 12/Aug/14 18:53
• Resolved: 11/Aug/14 22:01

Description

When registering ISO/Volume with CloudStack, it is necessary to provide a URL from which the ISO/Volume can be downloaded.

SO/Volume name checking currently just looks at the very end of the url string. e.g.:

private void checkFormat(String format, String url) {
if((!url.toLowerCase().endsWith("vhd"))

This breaks functionality for S3 pre-signed URL, or anything where the file extension is not the last part of the URL. We should at least attempt to parse the URL for filename vs parameters.